Repository navigation
Conversation
7 of 10 tasks
joragua
force-pushed
the
feature/permalink_sharing_ng
branch
3 times, most recently
from
October 16, 2026 12:23
8740a49 to
2ac30eb
Compare
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
joragua
force-pushed
the
feature/permalink_sharing_ng
branch
from
October 19, 2026 09:34
8372f01 to
0102a3f
Compare
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
joragua
force-pushed
the
feature/permalink_sharing_ng
branch
from
October 19, 2026 11:43
5964725 to
a256dfd
Compare
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
joragua
marked this pull request as ready for review
October 20, 2026 09:45
jesmrec
requested changes
Oct 20, 2026
| } | ||
|
|
||
| binding.permanentLinkButton.isVisible = false | ||
| val privateLinkDisabled = capabilities?.filesPrivateLinks == CapabilityBooleanType.FALSE |
Member
There was a problem hiding this comment.
If capabilities? is null, capabilities?.filesPrivateLinks is also null, so capabilities?.filesPrivateLinks == CapabilityBooleanType.FALSE is false.
Then, privateLinkDisabled is false. The condition below:
if (file.privateLink.isNullOrEmpty() || privateLinkDisabled) could be true if the privateLink is not null or empty, and the privateLink will be visible without having the capability value. Would this be dangerous?
Member
Author
There was a problem hiding this comment.
capabilities cannot be null at this point since they are checked before setting the oCIS layout. Removing nullability from this variable. Good catch! 👍🏻
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
jesmrec
approved these changes
Oct 20, 2026
jesmrec
left a comment
jesmrec
left a comment
Member
There was a problem hiding this comment.
CR approved, let's move to QA 🚀
jesmrec
self-requested a review
October 20, 2026 12:44
jesmrec
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #4939
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA